Release of talk track

[Michael Allan]

Hey guys,

Conseo's talk track is now running on the reference server.
http://zelea.com/project/votorola/home.html
It hasn't completely harvested as I post; it's still crawling back
into 2008 on the Metagov list.

We're finally in sync codewise.
http://zelea.com/var/db/repo/votorola/graph/e65337d94714

I bumped into a few minor problems: (1) The manual still has the wrong
instructions for harvesting.
http://zelea.com/project/votorola/s/manual.xht#line-voharvest

(2) Jay walking in a thread-safety zone:
http://zelea.com/var/db/repo/votorola/rev/463bb663a73d
It threw an assertion error.  You don't test with those enabled, C?

(3) I reverted the following change, and a similar one for MessageJS.
It's not wrong, but I figure the old version is faster and clearer.

    --- a/votorola/s/gwt/stage/DiffKeyS.java        Thu Sep 27 02:23:01 2012 +0200
    +++ b/votorola/s/gwt/stage/DiffKeyS.java        Sat Sep 29 18:25:53 2012 +0200
    @@ -19,12 +19,14 @@
         {
             public boolean equals( final DiffKey k1, final DiffKey k2 )
             {
    -            if( k1 == null ) return k2 == null;
    -            if( k2 == null ) return k1 == null;
    +            if( k1 == k2 ){
    +                return true;
    +            }

                 // cf. votorola.a.diff.DiffKey1
    -            return k1.a() == k2.a() && k1.aR() == k2.aR()
    -                && k1.b() == k2.b() && k1.bR() == k2.bR();
    +            return k1 instanceof DiffKey && k2 instanceof DiffKey
    +                    && k1.a() == k2.a() && k1.aR() == k2.aR()
    +                    && k1.b() == k2.b() && k1.bR() == k2.bR();
             }
         };

Four tracks down, one more to go!

Mike


conseo said:
> Hey,
> 
> I think I will find some to fix the update-button on the week-end or next 
> week. I am ok with waiting for my fix and points 1. and 2..
> Mike, can you also make the VoteTrack snap to the top of the page on draft 
> pages, when you scroll downwards, and settle in the stage again, when we 
> scroll to the top?
> 
> conseo
> 
> 
> Am Mittwoch, 14. November 2012, 07:35:22 schrieb Michael Allan:
> > Hey guys,
> > 
> > This is now fixed in my bug1 repo.  I was waiting on two other fixes
> > before pulling to the trunk and releasing it (along with the talk
> > track) to the ref server:
> > 
> >   1. Stable kick button in talk track:
> >      http://mail.zelea.com/list/votorola/2012-November/001501.html
> > 
> >   2. Moving talk track up, so vote track is on bottom.  I think
> >      the tracks should be ordered like this, if you agree:
> > 
> >        ^^ (X) ][ Q                                 P D D ][    (link)
> >        --------------------------------                        (poll)
> >                           ---------------------------------    (talk)
> > 
> >        >>>>>>>>>>>>>>>>>>> --- >>>>>>>>>>>>>>>>>> --- >>>>>    (vote)
> > 
> >      I think the vote track is happier on bottom because otherwise it
> >      rides over top of other tracks in drafts, its pin indicator gets
> >      in their way, and (on bridge) the anchor line doesn't connect:
> >     
> > http://zelea.com/project/votorola/_/javadoc/votorola/s/gwt/wic/AnchorLine.h
> > tml But it looks better with the poll track above talk track (still) because
> > the eye wants to travel from top left to bottom right.
> > 
> > Are you guys okay with these changes (when C gets time)?  Or should I
> > release it as is?
> > 
> > Mike