Release of talk track

[conseo]

Michael Allan wrote:
> Hey guys,
> 
> Conseo's talk track is now running on the reference server.
> http://zelea.com/project/votorola/home.html
> It hasn't completely harvested as I post; it's still crawling back
> into 2008 on the Metagov list.
> 
> We're finally in sync codewise.
> http://zelea.com/var/db/repo/votorola/graph/e65337d94714
Good!

> 
> I bumped into a few minor problems: (1) The manual still has the wrong
> instructions for harvesting.
> http://zelea.com/project/votorola/s/manual.xht#line-voharvest

Fixed that, will commit it with next changes.

> 
> (2) Jay walking in a thread-safety zone:
> http://zelea.com/var/db/repo/votorola/rev/463bb663a73d
> It threw an assertion error.  You don't test with those enabled, C?
Ooops :-/ missed that block. Hmm, have to look into it, seems I don't get the 
assertion errors.

> 
> (3) I reverted the following change, and a similar one for MessageJS.
> It's not wrong, but I figure the old version is faster and clearer.
Well, yes. I have taken that from "Effective Java" equals()-examples. Yours 
does here the same and this equals is different anyhow.

> 
>     --- a/votorola/s/gwt/stage/DiffKeyS.java        Thu Sep 27 02:23:01 2012
> +0200 +++ b/votorola/s/gwt/stage/DiffKeyS.java        Sat Sep 29 18:25:53
> 2012 +0200 @@ -19,12 +19,14 @@
>          {
>              public boolean equals( final DiffKey k1, final DiffKey k2 )
>              {
>     -            if( k1 == null ) return k2 == null;
>     -            if( k2 == null ) return k1 == null;
>     +            if( k1 == k2 ){
>     +                return true;
>     +            }
> 
>                  // cf. votorola.a.diff.DiffKey1
>     -            return k1.a() == k2.a() && k1.aR() == k2.aR()
>     -                && k1.b() == k2.b() && k1.bR() == k2.bR();
>     +            return k1 instanceof DiffKey && k2 instanceof DiffKey
>     +                    && k1.a() == k2.a() && k1.aR() == k2.aR()
>     +                    && k1.b() == k2.b() && k1.bR() == k2.bR();
>              }
>          };
> 
> Four tracks down, one more to go!
:-)

> 
> Mike

conseo