[PATCH] rename test-alias-accounts to guest-accounts
Michael Allan
mike at zelea.com
Tue Nov 20 12:51:29 EST 2012
Hey Conseo,
Your patch was difficult to read. The list thinks it's binary (see
bottom). Till we figure a fix, could you append patches directly to
the message body?
Comments MCA:
diff -r 9914a47c7880 votorola/a/locale/W.properties
--- a/votorola/a/locale/W.properties Sat Nov 17 04:12:26 2012 +0100
+++ b/votorola/a/locale/W.properties Tue Nov 20 17:41:54 2012 +0100
@@ -170,7 +170,7 @@
-a.web.wic.authen.WP_Login.or-test = login under an alias:
+a.web.wic.authen.WP_Login.or-guest = login as a guest:
MCA ^ better not change the property name on the left unless really
necessary. It requires moving wiki pages around.
a.web.wic.authen.WP_Login.alias = Alias
a.web.wic.authen.WP_Login.aliasDescription = Enter a nickname or other alias. You will have access to the vote-server as an authenticated user, but only for test purposes. Your input will eventually be erased.
diff -r 9914a47c7880 votorola/a/locale/W_de.properties
--- a/votorola/a/locale/W_de.properties Sat Nov 17 04:12:26 2012 +0100
+++ b/votorola/a/locale/W_de.properties Tue Nov 20 17:41:54 2012 +0100
@@ -146,9 +146,9 @@
-a.web.wic.authen.WP_Login.or-test = Einloggen als Test-Nutzer:
+a.web.wic.authen.WP_Login.or-guest = Einloggen als Gast-Nutzer:
MCA ^ same here
-a.web.wic.authen.WP_Login.aliasDescription = Geben Sie einen Alias ein. Sie bekommen dadurch Zugang zum Wahl-Server als ein authentifizierter Nutzer, aber alle Ihre Eingaben werden fr\u00fcher oder später wieder gel\u00f6scht.
+a.web.wic.authen.WP_Login.aliasDescription = Geben Sie einen Gast-Alias ein. Sie bekommen dadurch Zugang zum Wahl-Server als ein authentifizierter Nutzer, aber alle Ihre Eingaben werden fr\u00fcher oder später wieder gel\u00f6scht.
> ... We have to clean the current polls from the test-accounts at
> one point, at least beyond Sys/p/sandbox, imo. All other stuff like
> testing can happen in the dev environnment, so our test accounts
> should vanish unless they are really needed to test something,
> whereby they get removed afterwards. ...
Most of the test/simulation votes are here (Thomas wanted them here):
http://zelea.com:8080/v/w/Votespace?p=G!p!sandbox
It's worked out well. G!p!sandbox is for big demonstrations and tests
(future realistic), and Sys!p!sandbox is for smaller ones (current
realistic)! http://zelea.com:8080/v/w/Votespace?p=Sys!p!sandbox
Most other places, you can unvote them if you want. But after I pull
this patch, (I guess you know) the only way is to shell into the
vote-server and use the 'voter' shell, or psql.
> ... Maybe sim-* is better for Sys/p/sandbox as it suggests it is a
> simulation, which it really is. Is this reasonable? I don't suggest
> that as high priority, but I would like to clean up a little from
> time to time.
That's a little more expensive (as we discussed earlier), requiring
changes to manual and simulation scripts, and a little grepping to
ensure no code anywhere depends on the old scheme.
Also there's a related problem crying out to be fixed. When a user or
bot (or whatever) takes alias "Joe", then it translates to one of
these mailish usernames:
Test-joe-ZeleaCom | Sim-joe-ZeleaCom
Guest-joe-ZeleaCom
Those are horrid. It doesn't matter what we subsitute for "test". So
if you go for a deep fix, then it might be good to address this, too.
Maybe something like these?
Joe-test-ZeleaCom | Joe-sim-ZeleaCom
Joe-guest-ZeleaCom
Mike
conseo said:
> Hi,
>
> I have changed the login code to make real guest created votes distinct from
> test accounts (we also have sim-* account names btw.). We have to clean the
> current polls from the test-accounts at one point, at least beyond
> Sys/p/sandbox, imo. It looks like the whole polls are fake if more than 50%
> have a test account and in some polls you have test-a, test-b, etc. bot
> accounts. All other stuff like testing can happen in the dev environnment, so
> our test accounts should vanish unless they are really needed to test
> something, whereby they get removed afterwards. Maybe sim-* is better for
> Sys/p/sandbox as it suggests it is a simulation, which it really is. Is this
> reasonable? I don't suggest that as high priority, but I would like to clean
> up a little from time to time.
>
> conseo
> -------------- next part --------------
> A non-text attachment was scrubbed...
> Name: rename-test-alias-to-guest.patch
> Type: text/x-patch
> Size: 3365 bytes
> Desc: not available
> URL: <http://mail.zelea.com/list/votorola/attachments/20121120/9a8cd7c3/attachment.bin>
> _______________________________________________
> Votorola mailing list
> Votorola at zelea.com
> http://mail.zelea.com/mailman/listinfo/votorola
More information about the Votorola
mailing list